[PATCH] D122930: [Propeller] Promote functions with propeller profiles to .text.hot.

Thu May 5 11:47:54 PDT 2022

rahmanl added a comment.

In D122930#3492643 <https://reviews.llvm.org/D122930#3492643>, @shenhan wrote:

> This looks good to me.  One question, do we have a rough idea, what is the percentage of functions that pgo and propeller disagree about their hotness?

Yes. For one example we have 
31% of Propeller functions in .text.hot, 
57% in .text
11% in .text.unlikely

One questions is whether the promotion should be hidden behind a flag or not.

================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:485
     // This is a conservative behabvior.
-    if (F.hasFnAttribute(Attribute::Hot) ||
+    if (BBSectionsProfileReader->isFunctionHot(F.getName()) ||
+        F.hasFnAttribute(Attribute::Hot) ||
----------------
shenhan wrote:
> Are we sure BBSectionsProfileReader here is always not null?
Thanks. Added the check.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122930/new/

https://reviews.llvm.org/D122930