[PATCH] D123134: [demangler] No need to space adjacent template closings

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 11:31:20 PDT 2022


dblaikie added a subscriber: rjmccall.
dblaikie added a comment.

Doesn't look like all the cases are tested? (eg: I searched for `basic_iostream` and I only see the source change but no test change) - I realize some of these may be previously missing test coverage, but would you mind checking/adding the missing coverage?

& I think maybe @rjmccall had signed off on this direction in another review - could you link to his comment in the patch description? (or if I'm misremembering, maybe someone else had OK'd the direction?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123134/new/

https://reviews.llvm.org/D123134



More information about the llvm-commits mailing list