[PATCH] D124552: CodeGenPrepare: Replace constant PHI arguments with switch condition value

Thu May 5 09:59:05 PDT 2022

MatzeB added inline comments.

================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:6986
   Instruction::CastOps ExtOp;
   IntegerType *ExtType = TLI->shouldExtendSwitch(*SI, &ExtOp);
   if (!ExtType)
----------------
spatel wrote:
> spatel wrote:
> > Something isn't updated properly in this patch? I don't see this TLI hook defined in the previous patches or on current main.
> Ah - I didn't see the history in the previous patch in this set. So this patch just needs to be updated because the name/signature changed in D124894.
Yeah I didn't bother updating the rest of the stack when I updated the diffs further down. Updated it now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124552/new/

https://reviews.llvm.org/D124552