[PATCH] D125010: [MLIR] Fix build with make

Marius Brehler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 08:03:26 PDT 2022


marbre added a comment.

I am currently out-of-office and don‘t have any access to my build machines. Therefore, I cannot test and confirm that the patch doesn‘t have unintended side effects. However, there is definitely a need  to add a dependency to the tablgen generated header files. Sorry for missing this as part of https://reviews.llvm.org/D124851. I would suggest to take a look how this is done for MLIR dialects, where explicits deps to the generated targets are passed to `add_mlir_dialect_library` like in https://github.com/llvm/llvm-project/blob/04b419048955fc33718ba97e79f3558b6a27830e/mlir/lib/Dialect/EmitC/IR/CMakeLists.txt#L7-L9. It might not be necessary to touch AddLLVM and I assume the deps should rather be on the `*IncGen` target,


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125010/new/

https://reviews.llvm.org/D125010



More information about the llvm-commits mailing list