[PATCH] D124895: [Object] Fix updating darwin archives

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:117
 
+bool NewArchiveMember::isMacho() const {
+  auto Magic = identify_magic(Buf->getBuffer());
----------------
I feel like this function really belongs as a free function in either the BinaryFormat or Object libraries. If I'm not mistaken, the fact that the object is an archive member is irrelevant to this function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124895/new/

https://reviews.llvm.org/D124895