[PATCH] D123801: [DAG][PowerPC] Combine shuffle(bitcast(X), Mask) to bitcast(shuffle(X, Mask'))

[ChenZheng via Phabricator via llvm-commits]

shchenz accepted this revision as: shchenz.
shchenz added a comment.
This revision is now accepted and ready to land.

Thanks. The PowerPC part changes are improvements and LGTM.

But please wait for some days in case @nemanjai has some comments.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:2143
+  if (VT == MVT::v2i64 || VT == MVT::v2f64)
+    return EltSize == 8 && N->getMaskElt(0) == N->getMaskElt(1);
+
----------------
I think we may need to handle all other types(1/2/4/8 bytes) of splat load for shuffle_vector with same masks in all lanes, like what we do for build_vector on PowerPC. But that should not be this patch's scope.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123801/new/

https://reviews.llvm.org/D123801