[PATCH] D124967: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in partition's promotability checking

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/test/Transforms/SROA/lifetime-intrinsic.ll:1
+; RUN: opt < %s -passes=sroa -S | FileCheck %s
+target datalayout = "e-p:64:64:64-p3:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-i128:128:128-f32:32:32-f64:64:64-v16:16:16-v32:32:32-v64:64:64-v128:128:128-n16:32:64"
----------------
tra wrote:
> I'd add a comment describing what is it we're looking for here.
> It's not clear from the test itself why we're checking for those phys. To make sure that we don't do excessive shifting and masking of i32->i16->i32 ?
Generally, please reduce this test to the minimal instructions that show the problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124967/new/

https://reviews.llvm.org/D124967