[PATCH] D122930: [Propeller] Promote functions with propeller profiles to .text.hot.

[Han Shen via Phabricator via llvm-commits]

shenhan added a comment.

This looks good to me.  One question, do we have a rough idea, what is the percentage of functions that pgo and propeller disagree about their hotness?



================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:485
     // This is a conservative behabvior.
-    if (F.hasFnAttribute(Attribute::Hot) ||
+    if (BBSectionsProfileReader->isFunctionHot(F.getName()) ||
+        F.hasFnAttribute(Attribute::Hot) ||
----------------
Are we sure BBSectionsProfileReader here is always not null?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122930/new/

https://reviews.llvm.org/D122930