[PATCH] D124696: [SelectionDAG] Constant fold (sext_inreg undef, VT) to 0 instead of undef.

[Craig Topper via Phabricator via llvm-commits]

craig.topper updated this revision to Diff 427155.
craig.topper added a comment.

Replace undef with an argument in SystemZ test. Undef operands are a bad idea.

I have verified that reverting the change from https://www.llvm.org/PR46154
hits the original assertion failure on the modified test. That is the patch
that added the test. So I think it is still a valid test with this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124696/new/

https://reviews.llvm.org/D124696

Files:
  llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  llvm/test/CodeGen/AArch64/pr55178.ll
  llvm/test/CodeGen/SystemZ/regcoal_remat_empty_subrange.ll


Index: llvm/test/CodeGen/SystemZ/regcoal_remat_empty_subrange.ll
===================================================================
--- llvm/test/CodeGen/SystemZ/regcoal_remat_empty_subrange.ll
+++ llvm/test/CodeGen/SystemZ/regcoal_remat_empty_subrange.ll
@@ -11,18 +11,19 @@
 @g_151 = external dso_local global i32, align 4
 @g_222 = external dso_local unnamed_addr global [7 x [10 x i8]], align 2
 
-define void @main() {
+define void @main(i16 %in) {
 ; CHECK-LABEL: main:
 ; CHECK:       # %bb.0:
-; CHECK-NEXT:    lhi %r0, 1
+; CHECK-NEXT:    lhr %r2, %r2
 ; CHECK-NEXT:    larl %r1, g_151
 ; CHECK-NEXT:    lghi %r3, 0
-; CHECK-NEXT:    chi %r0, 0
+; CHECK-NEXT:    chi %r2, 0
+; CHECK-NEXT:    lhi %r0, 1
 ; CHECK-NEXT:    locghile %r3, 1
 ; CHECK-NEXT:    o %r0, 0(%r1)
-; CHECK-NEXT:    dsgfr %r2, %r0
 ; CHECK-NEXT:    larl %r1, g_222
 ; CHECK-NEXT:    lghi %r5, 0
+; CHECK-NEXT:    dsgfr %r2, %r0
 ; CHECK-NEXT:    stgrl %r2, g_39
 ; CHECK-NEXT:    stc %r5, 19(%r1)
 ; CHECK-NEXT:    br %r14
@@ -32,7 +33,7 @@
   %tmp5 = srem i64 0, %tmp4
   %tmp6 = trunc i64 %tmp5 to i8
   store i8 %tmp6, i8* getelementptr inbounds ([7 x [10 x i8]], [7 x [10 x i8]]* @g_222, i64 0, i64 1, i64 9), align 1
-  %tmp7 = icmp slt i16 undef, 1
+  %tmp7 = icmp slt i16 %in, 1
   %tmp8 = zext i1 %tmp7 to i64
   %tmp9 = srem i64 %tmp8, %tmp4
   store i64 %tmp9, i64* @g_39, align 8
Index: llvm/test/CodeGen/AArch64/pr55178.ll
===================================================================
--- llvm/test/CodeGen/AArch64/pr55178.ll
+++ llvm/test/CodeGen/AArch64/pr55178.ll
@@ -10,8 +10,9 @@
 ; CHECK-NEXT:    mov w8, #-113
 ; CHECK-NEXT:    // kill: def $w0 killed $w0 def $x0
 ; CHECK-NEXT:    lsl w8, w8, w0
-; CHECK-NEXT:    cmp w8, w8, sxtb
-; CHECK-NEXT:    cset w0, lt
+; CHECK-NEXT:    sxtb w8, w8
+; CHECK-NEXT:    cmp w8, #0
+; CHECK-NEXT:    cset w0, gt
 ; CHECK-NEXT:    ret
   %1 = shl i8 -113, %X
   %cmp = icmp slt i8 undef, %1
Index: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
===================================================================
--- llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -6224,9 +6224,9 @@
       std::swap(N1, N2);
     } else {
       switch (Opcode) {
-      case ISD::SIGN_EXTEND_INREG:
       case ISD::SUB:
         return getUNDEF(VT);     // fold op(undef, arg2) -> undef
+      case ISD::SIGN_EXTEND_INREG:
       case ISD::UDIV:
       case ISD::SDIV:
       case ISD::UREM:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124696.427155.patch
Type: text/x-patch
Size: 2476 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220504/2d31e1c9/attachment.bin>