[PATCH] D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:277
 
 void RISCVAsmPrinter::emitInstruction(const MachineInstr *MI) {
   // Do any auto-generated pseudo lowerings.
----------------
Zeavee wrote:
> reames wrote:
> > Seeing this on the AsmPrinter is suprising.  I'd have expected this code to be in RISCVMCInstLower.cpp.  Is there something I'm missing here?
> It seems to be the case for most architectures. It is true however that the lowering of those instructions should be in `RISCVMCInstLower.cpp` as it would be more consistent. Should I move it there?
You should ignore me here.  On a quick skim, I was confusing being in the MCInstLowering with not being on the AsmPrinter class.  I was wrong, and you have the right placement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123496/new/

https://reviews.llvm.org/D123496