[PATCH] D124878: [Bitcode] Include indirect users of BlockAddresses in bitcode

[Wende Tan via Phabricator via llvm-commits]

twd2 added inline comments.


================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:3416-3417
+        for (User *U : V->users()) {
+          if ((isa<ConstantData>(U) || isa<ConstantAggregate>(U) ||
+               isa<ConstantExpr>(U)) &&
+              !BlockAddressUsersVisited.contains(U)) {
----------------
nickdesaulniers wrote:
> Consider adding test coverage for 3 different types of Users.
Thanks for the comment!

I just find that `ConstantData`s take no operand, so `U` will never be a `ConstantData`. I'll remove this condition and add tests for the remaining 2 types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124878/new/

https://reviews.llvm.org/D124878