[PATCH] D124777: [IROutliner] Accommodate PHINodes with entry outside region for numbering

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:394
+  // NOTE: If this is updated such that the outlined block can have more than
+  // one incoming block to a PHINode, this logic will have to updated
+  // to handle multiple precessors instead.
----------------
Can we add an assert that we don't have multiple predecessors?


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1221
+        }
+      assert(PrevBlock && "PrevBlock is nullptr!");
       OGVN = Cand.getGVN(PrevBlock);
----------------
Probably can have a more useful message here; e.g.

"Expected to find a predecessor not in the region?" or something?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124777/new/

https://reviews.llvm.org/D124777