[PATCH] D124412: [BOLT] Report per-section hotness in bolt-heatmap.
Rahman Lavaee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 4 11:55:14 PDT 2022
rahmanl added inline comments.
================
Comment at: bolt/include/bolt/Profile/Heatmap.h:56-59
+ return (Address > MaxAddress) || (Address < MinAddress) ||
+ (!TextSections.empty() &&
+ (Address > TextSections.back().EndAddress ||
+ Address < TextSections.front().BeginAddress));
----------------
rafauler wrote:
> What happens if I want a heatmap that shows activity in addresses that are not mapped to a text section? (e.g. jitted code)
>
> We need to support recording samples in unmapped regions as well.
Good idea. I removed this check and instead added a separate (unmapped) entry in the text section hotness data.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124412/new/
https://reviews.llvm.org/D124412
More information about the llvm-commits
mailing list