[PATCH] D124942: [BOLT][NFC] Fix MCPlusBuilder::getAliases caching behavior

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 11:24:47 PDT 2022


Amir marked an inline comment as done.
Amir added inline comments.


================
Comment at: bolt/lib/Target/AArch64/AArch64MCPlusBuilder.cpp:1153
+  MCPlusBuilder *MIB = new AArch64MCPlusBuilder(Analysis, Info, RegInfo);
+  MIB->initAliases();
+  return MIB;
----------------
yota9 wrote:
> Maybe move it to the common MCPlusBuilder constructor?
That works too. Wasn't sure about invoking a virtual method from a base constructor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124942/new/

https://reviews.llvm.org/D124942



More information about the llvm-commits mailing list