[PATCH] D122251: [lit] Use sharding for GoogleTest format

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 11:22:05 PDT 2022


probinson added a comment.

> The buildbot totals are counting the number of shards across all unit tests. The summary at the end of the log is counting the number of test cases like before.

lit used to report (or include in the report) the number of individual test functions across all the unittests.  Now I believe it is reporting the number of shards, instead?  I should think the code in lit that parses googletest output should be able to extract the number of tests executed by each shard (and if not, it could be upgraded to do so).  That would recover the number that people have been expecting to see (both directly from lit, from buildbots, and possibly from metrics recorded elsewhere).

I wouldn't think it was a big deal, except that total number is in the tens of thousands.  I'm sure it is very surprising to people to have that huge drop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251



More information about the llvm-commits mailing list