[PATCH] D122091: [amdgpu] Elide module lds allocation in kernels with no callees

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

Drop the caching of the value and pass in function instead of module. No functional change to previous diff, simpler code.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMachineFunction.h:60
+  // This kernel calls no functions that require the module lds struct
+  bool CanElideModuleLDS = false;
+
----------------
arsenm wrote:
> arsenm wrote:
> > Probably not much value in caching this in MFI
> I guess might as well leave it since we have the others (although I'm not a huge fan of these cached fields we don't serialize)
It makes some WIP stuff cleaner to remove this, updating


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122091/new/

https://reviews.llvm.org/D122091