[PATCH] D122091: [amdgpu] Elide module lds allocation in kernels with no callees

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added inline comments.
Herald added a subscriber: jsilvanus.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMachineFunction.cpp:89
 void AMDGPUMachineFunction::allocateModuleLDSGlobal(const Module *M) {
   if (isModuleEntryFunction()) {
     const GlobalVariable *GV = M->getNamedGlobal("llvm.amdgcn.module.lds");
----------------
Not sure following the existing pattern makes sense here. Passing the function to allocateModuleLDSGlobal then checking the attribute in place is probably better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122091/new/

https://reviews.llvm.org/D122091