[PATCH] D124857: [AIX][PGO] Enable linux style PGO on AIX

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformLinux.c:253
+// variables in each of the above 3 sections.
+COMPILER_RT_VISIBILITY int dummy_cnts[0] COMPILER_RT_SECTION(
+    COMPILER_RT_SEG INSTR_PROF_CNTS_SECT_NAME);
----------------
This has a -Wzero-length-array warning in -pedantic mode.


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:860
+      TT.isOSSolaris() || TT.isOSFuchsia() || TT.isPS4() || TT.isOSWindows() ||
+      TT.isOSAIX())
     return false;
----------------
You may place AIX before others for a relatively alphabetical order.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124857/new/

https://reviews.llvm.org/D124857