[PATCH] D124903: [X86][AMX] Replace PXOR instruction with SET0 in AMX pre config.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:393
         .addReg(Ymm);
+  } else if (ST.hasAVX2()) {
+    Register Xmm = MRI->createVirtualRegister(&X86::VR128RegClass);
----------------
LuoYuanke wrote:
> pengfei wrote:
> > `hasAVX1`?
> Yes, I forgot to change it to hasAVX. Thanks.
AVX  should be a separate patch. Can you share most of the AVX and SSE2 code by picking the store opcode at the start of the block?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124903/new/

https://reviews.llvm.org/D124903