[PATCH] D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error

Wed May 4 02:21:37 PDT 2022

thieta added a comment.

In D124153#3487580 <https://reviews.llvm.org/D124153#3487580>, @awarzynski wrote:

> Thanks for seeing this through!
>
> Could you also update the CMake invocation in https://github.com/llvm/llvm-project/blob/be656df18721dc55a1de2eea64a3f73b6afa29a2/llvm/docs/GettingStarted.rst#getting-the-source-code-and-building-llvm? Or https://clang.llvm.org/get_started.html? There's probably going to be many more places like this.

I have hit a lot of these places in my latest revision now. But the clang website seems to be a checked in html file in the repo - I was unsure if this was generated or not.

I am tempted to merge this now and handle any other updates as other patches as we find them instead of holding this up any longer. Any objections @awarzynski ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153