[PATCH] D123678: [polly] migrate -polly-show to the new pass manager

[YangKeao via Phabricator via llvm-commits]

YangKeao added a comment.

In D123678#3490386 <https://reviews.llvm.org/D123678#3490386>, @Meinersbur wrote:

> When compiling under Windows with `cmake -DPOLLY_ENABLE_GPGPU_CODEGEN=ON`, I get a linker error:
>
>   Polly.lib(PPCGCodeGeneration.obj) : error LNK2019: unresolved external symbol "class llvm::Pass * __cdecl polly::createDOTOnlyPrinterPass(void)" (?createDOTOnlyPrinterPass at polly@@YAPEAVPass at llvm@@XZ) referenced in function "public: __cdecl `anonymous namespace'::PollyForcePassLinki
>   ng::PollyForcePassLinking(void)" (??0PollyForcePassLinking@?A0x3c23cca7@@QEAA at XZ) [C:\Users\meinersbur\build\llvm-project\debug_vs17\tools\opt\opt.vcxproj]
>   Polly.lib(PPCGCodeGeneration.obj) : error LNK2019: unresolved external symbol "class llvm::Pass * __cdecl polly::createDOTOnlyViewerPass(void)" (?createDOTOnlyViewerPass at polly@@YAPEAVPass at llvm@@XZ) referenced in function "public: __cdecl `anonymous namespace'::PollyForcePassLinking
>   ::PollyForcePassLinking(void)" (??0PollyForcePassLinking@?A0x3c23cca7@@QEAA at XZ) [C:\Users\meinersbur\build\llvm-project\debug_vs17\tools\opt\opt.vcxproj]
>   Polly.lib(PPCGCodeGeneration.obj) : error LNK2019: unresolved external symbol "class llvm::Pass * __cdecl polly::createDOTPrinterPass(void)" (?createDOTPrinterPass at polly@@YAPEAVPass at llvm@@XZ) referenced in function "public: __cdecl `anonymous namespace'::PollyForcePassLinking::Poll
>   yForcePassLinking(void)" (??0PollyForcePassLinking@?A0x3c23cca7@@QEAA at XZ) [C:\Users\meinersbur\build\llvm-project\debug_vs17\tools\opt\opt.vcxproj]
>   Polly.lib(PPCGCodeGeneration.obj) : error LNK2019: unresolved external symbol "class llvm::Pass * __cdecl polly::createDOTViewerPass(void)" (?createDOTViewerPass at polly@@YAPEAVPass at llvm@@XZ) referenced in function "public: __cdecl `anonymous namespace'::PollyForcePassLinking::PollyF
>   orcePassLinking(void)" (??0PollyForcePassLinking@?A0x3c23cca7@@QEAA at XZ) [C:\Users\meinersbur\build\llvm-project\debug_vs17\tools\opt\opt.vcxproj]
>   C:\Users\meinersbur\build\llvm-project\debug_vs17\Debug\bin\opt.exe : fatal error LNK1120: 4 unresolved externals [C:\Users\meinersbur\build\llvm-project\debug_vs17\tools\opt\opt.vcxproj]
>
> I could not yet find a config that also fails under Linux, but it looks like some library dependencies are wrong.

Is it a clean build? I guess there are some cache breaks the linking. The function `createDOTOnlyViewerPass` is removed and replaced by `createDOTOnlyViewerWrapperPass` in this commit. Check the `PollyForcePassLinking`, it only calls the `createDOTOnlyViewerWrapperPass`.

I'm not sure whether this problem shows potential "dependencies issues" (as it seems failed to invalidated the cache) in the build system.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123678/new/

https://reviews.llvm.org/D123678