[PATCH] D123528: [AVR] Always expand STDSPQRr & STDWSPQRr
Ben Shi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 3 23:50:15 PDT 2022
benshi001 added inline comments.
================
Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1220
+ MI.getOperand(0).setReg(STI.getFrameLowering()->hasReservedCallFrame(MF)
+ ? AVR::R29R28
+ : AVR::R31R30);
----------------
Could you please add cases to show the use of `R29R28` or `R31R30` in different situations ?
================
Comment at: llvm/test/CodeGen/AVR/stdwstk.ll:2
+; RUN: llc < %s -march=avr -mcpu=atmega328 -O1 | FileCheck %s
+; CHECK-NOT: stdwstk
+
----------------
I perfer the `.mir` tests in your previous https://reviews.llvm.org/D114611.
It would be better to seperate to STDWSPQRr.mir and STDSPQRr.mir.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123528/new/
https://reviews.llvm.org/D123528
More information about the llvm-commits
mailing list