[PATCH] D124350: [llvm-gsymutil][NFC] refactor AddressRange&AddresRanges structures.
Alexey Lapshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 3 22:20:43 PDT 2022
avl added inline comments.
================
Comment at: llvm/lib/Support/AddressRanges.cpp:24
+ if (It != It2) {
+ Range = {Range.start(), std::max(Range.end(), It2[-1].end())};
+ It = Ranges.erase(It, It2);
----------------
RKSimon wrote:
> @avl I'm seeing static analyzer warnings about using signed (negative) values into It2[] - maybe add a static cast?
Thanks! Will add cast.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124350/new/
https://reviews.llvm.org/D124350
More information about the llvm-commits
mailing list