[PATCH] D124834: [fastregalloc] Fix bug when undef value is tied to def.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 19:47:11 PDT 2022


MatzeB added inline comments.


================
Comment at: llvm/lib/CodeGen/RegAllocFast.cpp:1118
+    unsigned TiedIdx = MI.findTiedOperandIdx(Idx);
+    auto TiedMO = MI.getOperand(TiedIdx);
+    return TiedMO.isUndef();
----------------
Please avoid `auto` when the type isn't immediately visible within the same line, it makes the code easier to read. See https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124834/new/

https://reviews.llvm.org/D124834



More information about the llvm-commits mailing list