[PATCH] D123508: GlobalISel: Allow forming atomic/volatile G_ZEXTLOAD

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

I don't feel comfortable reviewing this given lack of experience with global isel and aarch64, but I wanted to add a bit of context which might help explain some of the confusion about the code structure.

A while back I had started a transition for x86 from using a separate ATOMIC_LOAD opcode to using a generic load with appropriate atomic bits set.  Unfortunately, I hit an issue in legalization that I got stuck on, and then got distracted and pulled away.  As such, I suspect the code is in a somewhat misleading form.   I vaguely remember the legalization issue as having something to do with atomic floating point loads, but I'm really not sure about that.

At a high level, I do very much think having atomic loads simply be normal loads with some atomic flags makes a lot of sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123508/new/

https://reviews.llvm.org/D123508