[PATCH] D124654: [AIX] Handling the label alignment of a global variable with its multiple aliases.

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 12:59:07 PDT 2022


DiggerLin added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2463
+  DenseMap<uint64_t, SmallVector<const GlobalAlias *, 1>> AliasList;
+  for (const GlobalAlias *GA : GOAliasMap[GV]) {
+    AliasList[getAliasOffset(GA->getAliasee())].push_back(GA);
----------------
only one line code, do not need {  and }


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2470
+  if (LabelForGV && AliasList.begin()->first != 0)
+    emitGlobalConstant(DL, GV->getInitializer());
+
----------------
need a test case for the code ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124654/new/

https://reviews.llvm.org/D124654



More information about the llvm-commits mailing list