[PATCH] D124834: [fastregalloc] Fix bug when undef value is tied to def.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 11:00:41 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/RegAllocFast.cpp:1115
 
+  auto IsTiedDef = [&](unsigned Idx) {
+    MachineOperand &MO = MI.getOperand(Idx);
----------------
Might as well pass in MachineOperand since that's what you already have at the use points 


================
Comment at: llvm/test/CodeGen/X86/fastregalloc-tied-undef.mir:5-26
+--- |
+  define dso_local void @foo() {
+  entry:
+    %vec = alloca [4 x <4 x float>], align 16
+    %m = alloca <4 x float>, align 16
+    store <4 x float> zeroinitializer, ptr %m, align 16
+    %0 = load <4 x float>, ptr %m, align 16
----------------
Can drop the IR section if you drop the block names and IR value references


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124834/new/

https://reviews.llvm.org/D124834



More information about the llvm-commits mailing list