[PATCH] D124653: [ELF] Fix branch range computation when picking ThunkSection

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 08:35:48 PDT 2022


MaskRay added a comment.

In D124653#3488163 <https://reviews.llvm.org/D124653#3488163>, @peter.smith wrote:

> Looks good to me.
>
> IIUC the problem case is triggered by relocations with addends. Something like:
>
> - ThunkSection selected which is in range of the branch, but not branch + offset.
> - Later code identifies the thunk is out of branch range which removes the thunk from the branch
> - Branch chooses the same thunk section as before.
> - Repeat, until error message.

Yes, this. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124653/new/

https://reviews.llvm.org/D124653



More information about the llvm-commits mailing list