[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

David Goldman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 07:01:50 PDT 2022


dgoldman accepted this revision.
dgoldman added a comment.
This revision is now accepted and ready to land.

In D124715#3484058 <https://reviews.llvm.org/D124715#3484058>, @stefanhaller wrote:

> Fix documentation of ThreadPriority::Low (was: Background), and move it up from
> set_thread_priority to ThreadPriority.
>
> (Is it ok that there's no documentation left for set_thread_priority? I couldn't
> come up with anything that's not trivial and redundant, e.g. "Sets the priority
> of the current thread.")

LGTM, no need for a trivial comment, the priorities themselves are documented.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124715/new/

https://reviews.llvm.org/D124715



More information about the llvm-commits mailing list