[PATCH] D113897: [GVNSink] Make GVNSink resistant against self referencing instructions (PR36954)

Dawid Jurczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 05:55:37 PDT 2022


yurai007 updated this revision to Diff 426672.
yurai007 edited the summary of this revision.
yurai007 added a comment.

Now basic blocks reachable from entry are collected up front only once before function sinking. 
Another option would be doing it in flight but now we are processing instructions in reverse order starting from bottom block via ReversePostOrderTraversal.
I guess it would make collecting visited and reachable BBs from entry less straightforward than there is now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113897/new/

https://reviews.llvm.org/D113897

Files:
  llvm/lib/Transforms/Scalar/GVNSink.cpp
  llvm/test/Transforms/GVNSink/sink-common-code.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113897.426672.patch
Type: text/x-patch
Size: 3633 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220503/25728612/attachment.bin>


More information about the llvm-commits mailing list