[PATCH] D124754: Minimal refactor of TargetTransformInfoImpl.h to avoid Clang Static Analyser's core.CallAndMessage (NFC)
Bjorn Pettersson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 3 01:12:32 PDT 2022
bjope accepted this revision.
bjope added a comment.
This revision is now accepted and ready to land.
LGTM!
This seem to help out avoiding complaints from clangsa that the OpTy passed on to getCastInstrCost could be a nullptr (implementations of getCastInstrCost doesn't seem to check that the Src/Dst Type pointers are non-null. One could perhaps question the API (if those pointers must not be null then I guess one could have passed the Type arguments by reference instead of passing the pointer). This patch in itself seem good anyway.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124754/new/
https://reviews.llvm.org/D124754
More information about the llvm-commits
mailing list