[PATCH] D123678: [polly] migrate -polly-show to the new pass manager

YangKeao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 01:01:06 PDT 2022


YangKeao added inline comments.


================
Comment at: polly/include/polly/ScopGraphPrinter.h:52
+template <>
+struct DOTGraphTraits<ScopDetection *> : public DOTGraphTraits<RegionNode *> {
+  DOTGraphTraits(bool isSimple = false)
----------------
Meinersbur wrote:
> YangKeao wrote:
> > I realized that this specialization doesn't take effect. I should use `DOTGraphTraits<ScopDetection>`.
> Are you going to make this change?
Yes. I'm doing it right now (after the Labor Day holiday 😄 )


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123678/new/

https://reviews.llvm.org/D123678



More information about the llvm-commits mailing list