[PATCH] D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

LGTM, aside from @hans's comment.



================
Comment at: llvm/docs/ReleaseNotes.rst:74
+  an error. You now have to pass ``-DCMAKE_BUILD_TYPE=<type>`` in order to configure
+  LLVM.
+
----------------
hans wrote:
> Should we add a paragraph which includes the motivation, explaining the problem, and perhaps linking to the docs which will help the user make the right choice?
+1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153