[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 00:09:49 PDT 2022


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-symbolizer/data-location.yaml:46
+## symbolized correctly. In future (if D123534 gets merged), this can be updated
+## to include a check that llvm-symbolize can also symbolize constant strings,
+## like `const char* string = "123456"` (and &"123456" should be symbolizable)
----------------
Nit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123538/new/

https://reviews.llvm.org/D123538



More information about the llvm-commits mailing list