[PATCH] D122835: [SCEV] Fix a bug that caused an invalid assertion.

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 22:33:31 PDT 2022


aqjune added a comment.

Hi, sorry for my delay. The old assertion seems problematic.

+1 for totally removing the assertion as well, because in the select case the `Sequential` flag must be set, calling ScalarEvolution::getSequentialMinMaxExpr at last. The assert condition was for dealing with select form however.
Also, the `condition (3)` even seems to be removed now; originally it was introduced here: D93882 <https://reviews.llvm.org/D93882>, but now gone.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122835/new/

https://reviews.llvm.org/D122835



More information about the llvm-commits mailing list