[PATCH] D114845: [llvm] [Debuginfod] DebuginfodCollection and DebuginfodServer for tracking local debuginfo.

[Noah Shutty via Phabricator via llvm-commits]

noajshu added a comment.

Thank you to all of the reviewers for your extremely helpful comments!

I believe there are no unresolved comments at this point, however I have two questions:

First, I wonder if it wouldn't hurt to add a `/source` endpoint, which doesn't check the local `DebuginfodCollection` at all but simply skips straight to using the client.
This way, users who run a local debuginfod server would only have to set all their known public servers in the `DEBUGINFOD_URLS` variable once when they start `llvm-debuginfod`. When they use a client tool (like `llvm-symbolizer`) it would suffice to point to their local server only, as all requests would be federated.

Second, I was wondering if there is any desire to split this out into two or more diffs. For example, although the changes to ThreadPool and Symbolize are quite small I'm happy to separate them out if desired.

Thank you!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114845/new/

https://reviews.llvm.org/D114845