[PATCH] D124678: [AMDGPU] Allow for MFMA Inst Clustering

[Austin Kerbow via Phabricator via llvm-commits]

kerbowa added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/mfma-cluster.mir:1
+# REQUIRES : asserts
+# RUN: llc -march=amdgcn -mcpu=gfx90a -run-pass=machine-scheduler %s -o - --debug-only=amdgpu-subtarget,machine-scheduler  2>&1 | FileCheck -check-prefix=DEFAULT %s
----------------
This test might be difficult to maintain. You might want to add two different test files. One file that doesn't require asserts which has many tests and has check lines autogenerated with update_mir_test_checks.py.

The test that requires asserts could just be a simple function to see if the clustering is working via the debug output, something that wouldn't be expected to change.


================
Comment at: llvm/test/CodeGen/AMDGPU/mfma-cluster.mir:28
+
+# PRERA: *** Final schedule for %bb.0 ***
+# PRERA-NEXT: SU(0):   $vgpr1 = V_MOV_B32_e32 1, implicit $exec
----------------
Generally, the check lines should come before the function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124678/new/

https://reviews.llvm.org/D124678