[PATCH] D124588: [BOLT] Warn about the number of mismatched branches

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 17:30:36 PDT 2022


paulkirth updated this revision to Diff 426548.
paulkirth added a comment.

Since reporting mismatched branches here is redundant, we can just remove the unused variable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124588/new/

https://reviews.llvm.org/D124588

Files:
  bolt/lib/Profile/DataReader.cpp


Index: bolt/lib/Profile/DataReader.cpp
===================================================================
--- bolt/lib/Profile/DataReader.cpp
+++ bolt/lib/Profile/DataReader.cpp
@@ -392,7 +392,6 @@
     }
   }
 
-  uint64_t MismatchedBranches = 0;
   for (const BranchInfo &BI : FBD->Data) {
     if (BI.From.Name != BI.To.Name)
       continue;
@@ -401,7 +400,6 @@
                       BI.Mispreds)) {
       LLVM_DEBUG(dbgs() << "bad branch : " << BI.From.Offset << " -> "
                         << BI.To.Offset << '\n');
-      ++MismatchedBranches;
     }
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124588.426548.patch
Type: text/x-patch
Size: 572 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220503/90f4297c/attachment.bin>


More information about the llvm-commits mailing list