[PATCH] D124588: [BOLT] Warn about the number of mismatched branches

[Rafael Auler via Phabricator via llvm-commits]

rafauler requested changes to this revision.
rafauler added a comment.
This revision now requires changes to proceed.

Thanks for finding this issue. This was originally introduced in d15b93badec2ffdfc6e5a01b9386cdefb4ea59ac <https://reviews.llvm.org/rGd15b93badec2ffdfc6e5a01b9386cdefb4ea59ac> by @maksfb . I'm not sure he had the intent of reporting these, probably not. By looking at the code now, when we reach these lines, we should've already gone through a call to evaluateProfileData, which is the real function that is taking care of seeing how many mismatches we have and reporting these. That's why I see no reason to report this here, so you can change this diff to just remove the declaration of MismatchedBranches and ++MismatchedBranches++.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124588/new/

https://reviews.llvm.org/D124588