[PATCH] D105069: [GlobalISel] Add re-association combine for G_PTR_ADD to allow better addressing mode usage.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.
Herald added a project: All.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:4171
+
+  for (auto &UseMI : MRI.use_nodbg_instructions(Src1Reg)) {
+    // This combine may end up running before ptrtoint/inttoptr combines
----------------
sorry to dig up an old patch, but I think this should be checking the users of PtrAdd. See https://reviews.llvm.org/D124644


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105069/new/

https://reviews.llvm.org/D105069