[PATCH] D124644: [DAGCombiner] reassociationCanBreakAddressingModePattern should check uses of the outer add.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 16:16:58 PDT 2022


craig.topper added a comment.

In D124644#3487024 <https://reviews.llvm.org/D124644#3487024>, @luismarques wrote:

> @craig.topper Have you checked if `CombinerHelper::reassociationCanBreakAddressingModePattern` (in `llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp`) is sound?

After a quick glance, I think it has the same issue. Was it copied from your original patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124644/new/

https://reviews.llvm.org/D124644



More information about the llvm-commits mailing list