[PATCH] D124808: GlobalISel: Trivial documentation and comment fixes
Nicolai Hähnle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 2 15:41:51 PDT 2022
nhaehnle created this revision.
Herald added a subscriber: rovka.
Herald added a project: All.
nhaehnle requested review of this revision.
Herald added a project: LLVM.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D124808
Files:
llvm/docs/GlobalISel/GenericOpcode.rst
llvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
Index: llvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
===================================================================
--- llvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
+++ llvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
@@ -1449,8 +1449,8 @@
/// Build and insert \p Res = G_SUB \p Op0, \p Op1
///
- /// G_SUB sets \p Res to the sum of integer parameters \p Op0 and \p Op1,
- /// truncated to their width.
+ /// G_SUB sets \p Res to the difference of integer parameters \p Op0 and
+ /// \p Op1, truncated to their width.
///
/// \pre setBasicBlock or setMI must have been called.
/// \pre \p Res, \p Op0 and \p Op1 must be generic virtual registers
@@ -1466,7 +1466,7 @@
/// Build and insert \p Res = G_MUL \p Op0, \p Op1
///
- /// G_MUL sets \p Res to the sum of integer parameters \p Op0 and \p Op1,
+ /// G_MUL sets \p Res to the product of integer parameters \p Op0 and \p Op1,
/// truncated to their width.
///
/// \pre setBasicBlock or setMI must have been called.
Index: llvm/docs/GlobalISel/GenericOpcode.rst
===================================================================
--- llvm/docs/GlobalISel/GenericOpcode.rst
+++ llvm/docs/GlobalISel/GenericOpcode.rst
@@ -405,8 +405,8 @@
G_UMULH, G_SMULH
^^^^^^^^^^^^^^^^
-Multiply two numbers at twice the incoming bit width (signed) and return
-the high half of the result.
+Multiply two numbers at twice the incoming bit width (unsigned or signed) and
+return the high half of the result.
.. code-block:: none
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124808.426535.patch
Type: text/x-patch
Size: 1545 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220502/e1c71558/attachment-0001.bin>
More information about the llvm-commits
mailing list