[PATCH] D121727: [NVPTX] Integrate ptxas to LIT tests

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 14:34:27 PDT 2022


tra added a comment.

In D121727#3481635 <https://reviews.llvm.org/D121727#3481635>, @probinson wrote:

> This feels like (maybe is?) supporting a target whose assembler happens not to be generally distributed, but which LLVM still supports as a target.  
> For those environments/bots that actually have the assembler installed, having that extra level of validation seems worthwhile.

That is exactly the case.

> But perhaps this discussion should be taking place on discourse, not in a review?

Sure. If @thakis has further concerns or questions, I'll be happy to continue the discussion there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121727/new/

https://reviews.llvm.org/D121727



More information about the llvm-commits mailing list