[PATCH] D124565: [mlgo] Support exposing more features than those supported by models

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 13:08:30 PDT 2022


mtrofin added a comment.

In D124565#3481794 <https://reviews.llvm.org/D124565#3481794>, @yundiqian wrote:

> what restricts that "the new features must be appended at the end of the list of features requested from the model"?

It's a requirement for development mode only (updated to clarify). To your question, see TFUtils.cpp, lines 303 and then the added lines 309 and below.

> Wondering whether it is possible to relax this constraint cause it may cause trouble if there are multiple developers for the same pass

How?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124565/new/

https://reviews.llvm.org/D124565



More information about the llvm-commits mailing list