[PATCH] D124643: [Object][DX] Initial DXContainer parsing support

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 12:50:05 PDT 2022


nikic added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/DXContainer.h:67
+  uint8_t Magic[4]; // "DXBC"
+  Hash Hash;
+  ContainerVersion Version;
----------------
This breaks the build with some versions of GCC:
```

In file included from /root/llvm-compile-time-tracker/llvm-project/llvm/include/llvm/Object/DXContainer.h:19,
                 from /root/llvm-compile-time-tracker/llvm-project/llvm/lib/Object/DXContainer.cpp:9:
/root/llvm-compile-time-tracker/llvm-project/llvm/include/llvm/BinaryFormat/DXContainer.h:67:8: error: declaration of ‘llvm::dxbc::Hash llvm::dxbc::Header::Hash’ changes meaning of ‘Hash’ [-fpermissive]
   67 |   Hash Hash;
      |        ^~~~
/root/llvm-compile-time-tracker/llvm-project/llvm/include/llvm/BinaryFormat/DXContainer.h:38:8: note: ‘Hash’ declared here as ‘struct llvm::dxbc::Hash’
   38 | struct Hash {
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124643/new/

https://reviews.llvm.org/D124643



More information about the llvm-commits mailing list