[PATCH] D124797: [memprof] Only insert dynamic shadow load when needed

Snehasish Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 12:47:06 PDT 2022


snehasish accepted this revision.
snehasish added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/test/Instrumentation/HeapProfiler/no-instrumentation.ll:14
+
+;; We should not add any instrumentation related code
+; CHECK: define void @_Z3foov
----------------
Can we also add a check for the log line "MEMPROF done instrumenting:"? Otherwise this test won't fail if memprof instrumentation doesn't run.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124797/new/

https://reviews.llvm.org/D124797



More information about the llvm-commits mailing list