[PATCH] D124794: [LLD][RISCV][NFC] Allow GNU linker to run RISCV LLD tests

Greg McGary via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 12:29:10 PDT 2022


gkm added a comment.

In D124794#3486452 <https://reviews.llvm.org/D124794#3486452>, @jrtc27 wrote:

> What happens when we want to use LLD-specific options or are checking LLD-specific messages? Those tests aren't going to pass. Do we then need to annotate LLD tests with `REQUIRES: lld-is-actually-lld`? Is there any precedent for doing this on other architectures? This doesn't feel right to me.

This is a developer aid for periodically checking divergences in behavior, it is not for production or routine use.
Failed tests are tolerable, and might merit a comment on a case-by-case basis.
There is precedent for testing against other linkers, e.g., MachO LLD vs. LD64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124794/new/

https://reviews.llvm.org/D124794



More information about the llvm-commits mailing list