[PATCH] D124734: [AMDGPU] Fix scalar_to_vector for v8i16/v8f16

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:5969
+
+  assert(ResultVecSize == 128);
+
----------------
Not much point in the assert since this works for any size 


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:5978
+
+  return lowerBUILD_VECTOR(DAG.getBuildVector(ResultVT, SL, VElts), DAG);
+}
----------------
Just return the build_vecotr. You are potentially missing combine opportunities by directly lowering it 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124734/new/

https://reviews.llvm.org/D124734