[PATCH] D123400: [LoopCacheAnalysis] Consider dimension depth of the subscript reference when calculating cost

Mon May 2 12:05:13 PDT 2022

congzhe added a comment.

In D123400#3486341 <https://reviews.llvm.org/D123400#3486341>, @bmahjour wrote:

> Sorry for the delay, as I didn't get a chance to commit this before I went on vacation.
>
> I just noticed that after fixed-size delinearization commit went in, this patch needed to be re-based and new values needed to be generated for the newly added `LoopnestFixedSize.ll`. I also noticed that this test exposes an issue with the analysis producing large cost values that can overflow the underlying int64_t type. This problem is not specific to this patch, as described in https://github.com/llvm/llvm-project/issues/55233. I think the overflow problem should be dealt with as a separate issue and will add it to the agenda for the next LoopOptWG call. In the mean time I've changed `LoopnestFixedSize.ll` to use smaller trip counts. @congzhe please let me know if you are ok with this change. We should recreate a test with large sizes as part of fixing 55233.

Thanks, I agree that we can merge this patch and then resolve the overflow issue.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123400/new/

https://reviews.llvm.org/D123400