[PATCH] D108699: [LAA] Analyze pointers forked by a select

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 11:41:57 PDT 2022


fhahn added a comment.

In D108699#3445309 <https://reviews.llvm.org/D108699#3445309>, @huntergr wrote:

> In D108699#3441724 <https://reviews.llvm.org/D108699#3441724>, @fhahn wrote:
>
>> Thanks for the update!
>>
>> I think it would be good to split this up to have a first patch that just adds very limited support in `findForkedSCEVs` and then gradually add support for more cases separately. This also makes it easier to make sure all code paths in `findForkedSCEVs` are covered by the unit tests.
>>
>> I went ahead and rebased D114487 <https://reviews.llvm.org/D114487> and stripped the fork analysis to the bare minimum. I'd be happy to land the scaffolding in D114487 <https://reviews.llvm.org/D114487> separately and this patch and following could add the sophisticated fork analysis.
>
> Sure, that sounds like a good plan. I'll try and review your patch this week.

Sounds great, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108699/new/

https://reviews.llvm.org/D108699



More information about the llvm-commits mailing list